Revert "[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] net: Fix kabi breakage for skbuff by exclude header"#1496
Closed
opsiff wants to merge 1 commit intolinux-6.6.yfrom
Closed
Conversation
This reverts commit ebe57af.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReverts a previous Deepin-specific KABI workaround around GRO header sizing in skbuff, restoring the standard inclusion of <net/gro.h> without CONFIG_DEEPIN_KABI_RESERVE conditionals and custom GRO_MAX_HEAD macro. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since CONFIG_DEEPIN_KABI_RESERVE is no longer special-cased here, double-check that there are no remaining references elsewhere that still assume a custom GRO_MAX_HEAD or different skb headroom when this config is set.
- Consider briefly documenting in the commit message why reverting to the upstream gro.h behavior is now safe for Deepin-specific KABI requirements, to clarify the rationale for future maintainers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since CONFIG_DEEPIN_KABI_RESERVE is no longer special-cased here, double-check that there are no remaining references elsewhere that still assume a custom GRO_MAX_HEAD or different skb headroom when this config is set.
- Consider briefly documenting in the commit message why reverting to the upstream gro.h behavior is now safe for Deepin-specific KABI requirements, to clarify the rationale for future maintainers.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1379
Summary by Sourcery
Enhancements: